fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/12452 )
Change subject: gsup: add OSMO_GSUP_SUPPORTED_RAT_TYPES_IE and OSMO_GSUP_CURRENT_RAT_TYPE_IE ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/12452/4/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/#/c/12452/4/include/osmocom/gsm/gsup.h@381 PS4, Line 381: supported_rat_types I just realized that this field could be a bitmask, e.g. uint8_t (hopefully, 6G and 7G are not coming any time soon). Just an idea, not a merge blocker. https://gerrit.osmocom.org/#/c/12452/4/src/gsm/gsup.c File src/gsm/gsup.c: https://gerrit.osmocom.org/#/c/12452/4/src/gsm/gsup.c@880 PS4, Line 880: if (!gsup_msg->supported_rat_types[i] || I think this check makes more sense for decoding rather than for encoding, where a compiler would warn on setting a value which is not a part of the enumerated type. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/12452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I93850710ab55a605bf61b95063a69682a2899bb1 Gerrit-Change-Number: 12452 Gerrit-PatchSet: 4 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sun, 29 Sep 2019 19:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
