fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15660 )
Change subject: add osmo_fsm_inst_watch() ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG@20 PS2, Line 20: immediate error handling directly terminated and deallocated bar Looking at the problem from the other side: can we delay deallocation of the FSM instances and move it to osmo_select_main()? This way calling osmo_fsm_inst_term() would not deallocate a given FSM immediately, but just mark it as 'to be deallocated' instead, and you will be sure that bar still exists (we may want to discard all events in such case). https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG@32 PS2, Line 32: osmo_fsm_inst_watch More I learn Erlang, more I realize that we're basically reimplementing basic primitives that it already has. At least this could be done using 'erlang:monitor/2'. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d8306488506c60b4c2fc1c4cb3ac04654db9c43 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2019 07:33:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
