pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 )
Change subject: pcu: Introduce some function helpers ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn@570 PS1, Line 570: f_pad_oct(data, 23, '00'O); /* CS-1 */ > We may want different coding schemes in the future, so the amount of padding > may vary. […] I think it's better to add them whenever we need them in the commit requiring the param. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8608fac4375153d5020df5d05026513a7fe931d6 Gerrit-Change-Number: 15664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2019 19:35:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
