pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15615 )
Change subject: bts-trx: Get rid of messy transceiver_available state handler ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/15615/5/src/osmo-bts-trx/l1_if.c File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/#/c/15615/5/src/osmo-bts-trx/l1_if.c@214 PS5, Line 214: PHY_LINK_SHUTDOWN > In which state it needs to be? PHY_LINK_CONNECTING or PHY_LINK_CONNECTED? !PHY_LINK_SHUTDOWN, either of CONNECTING or CONNECTED. during CONNECTING commands are sent to configure the TRX and move it to CONNECTED state, and during CONNECTED state still some configs can be changed (after POWERON), and POWEROFF is sent. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I35f4697bd33dbe8a4c76c9500b82c16589c701d4 Gerrit-Change-Number: 15615 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sat, 05 Oct 2019 20:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
