pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676 )
Change subject: pcu: Introduce test TC_t3169 ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@658 PS2, Line 658: f_rx_pcuif_rlcmac_dl_block_exp_dummy > Same comment as for 15675, do we really need to create functions for such > basic things? IMHO, this d […] I think it's handy once you start adding more and more tests and you end up having test files with 3K lines, at least we get rid of a few lines ;) When tests start to become more complex I think it really helps because you can abstract implementation details (like how you are matching exactly, error conditions, etc.). Furthermore if you want to do more checks, you simply extend one part of the code instead of having to apply same change all over. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I587413a7de7956daee3423057530e4052a55ba88 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2019 09:09:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilira...@gmail.com> Gerrit-MessageType: comment
