pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-pcu/+/15682 )
Change subject: pcu_l1_if.cpp: Fix GSMTAP Imm Assign PCH wrong encoding
......................................................................
pcu_l1_if.cpp: Fix GSMTAP Imm Assign PCH wrong encoding
Wireshark expects to receive the plen in order to decode it.
Fixes: 58543709e422ce6ba20baa232e6a5aced9b99164
Change-Id: I91d1354689300b949760cdbaee03294eab958e12
---
M src/pcu_l1_if.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index ac04663..6a0d58e 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -238,7 +238,7 @@
data[3] = (plen << 2) | 0x01;
if (bts->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_PCH))
- gsmtap_send(bts->gsmtap, 0, 0, GSMTAP_CHANNEL_PCH, 0, 0, 0, 0,
data + 4, 23);
+ gsmtap_send(bts->gsmtap, 0, 0, GSMTAP_CHANNEL_PCH, 0, 0, 0, 0,
data + 3, 23);
pcu_tx_data_req(0, 0, PCU_IF_SAPI_PCH, 0, 0, 0, data, 23+3);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15682
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I91d1354689300b949760cdbaee03294eab958e12
Gerrit-Change-Number: 15682
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
