pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15701 )
Change subject: ranap: add non-spec T1001 ...................................................................... Patch Set 2: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/15701/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15701/2//COMMIT_MSG@10 PS2, Line 10: and waits for a Release Complete. Use T1001 to release the Iu connection If it's non-spec, then we name them X1001, and values are negative. https://gerrit.osmocom.org/#/c/15701/2/src/sgsn/gprs_ranap.c File src/sgsn/gprs_ranap.c: https://gerrit.osmocom.org/#/c/15701/2/src/sgsn/gprs_ranap.c@180 PS2, Line 180: unsigned long T1001; X1001 https://gerrit.osmocom.org/#/c/15701/2/src/sgsn/gprs_ranap.c@188 PS2, Line 188: T1001 = osmo_tdef_get(sgsn->cfg.T_defs, 1001, OSMO_TDEF_S, -1); -1001 https://gerrit.osmocom.org/#/c/15701/2/src/sgsn/sgsn_vty.c File src/sgsn/sgsn_vty.c: https://gerrit.osmocom.org/#/c/15701/2/src/sgsn/sgsn_vty.c@112 PS2, Line 112: { .T=-1001, .default_val=NONSPEC_T1001_SECS, .desc="RANAP Release timeout. Wait for RANAP Release Complete." Please put it before -3314, we usually order them this way afaik. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I39a0169c22a4ac430b3d6f3c281d1f381eaa4756 Gerrit-Change-Number: 15701 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2019 12:58:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
