pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15702 )
Change subject: bts-trx: Log TRXC and TRXD socket recv()/send() failures ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c@104 PS1, Line 104: strerror_r > This is a single thread application, so calling strerror() would be enough. I prefer using stack-buffer functions, it's less prone to errors in the future. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic3e41d82b43459495d45873d612a3bd349ac174a Gerrit-Change-Number: 15702 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2019 13:52:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilira...@gmail.com> Gerrit-MessageType: comment