pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15704 )

Change subject: sgsn_mm_ctx_alloc(): check for unallocated fsms
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15704/1/src/sgsn/gprs_sgsn.c
File src/sgsn/gprs_sgsn.c:

https://gerrit.osmocom.org/#/c/15704/1/src/sgsn/gprs_sgsn.c@270
PS1, Line 270:          osmo_fsm_inst_free(ctx->iu.mm_state_fsm);
I'd expect osmo_fsm_inst_free() to guard against NULL pointers (free functions 
usually do). Can you check it?



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15704
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I867612a60236eaf7009400c92f5d871006aaf008
Gerrit-Change-Number: 15704
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2019 15:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to