lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 )
Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY ...................................................................... Patch Set 5: (1 comment) mind the ! https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c@668 PS5, Line 668: != this gremlin here is well known. it looked to me quite ugly to have if (state == ..) {} else { OSMO_ASSERT() } ST_MM_IDLE should never get through this. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2019 17:04:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
