laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15698 )
Change subject: tests/test_nodes.vty: check less libosmocore cmds ...................................................................... tests/test_nodes.vty: check less libosmocore cmds Use three dots to avoid checking for exact commands between help and exit, which originate from libosmocore. This avoids test failues when we slightly change the commands, like the change from "write file" to "write file [PATH]" in [1] that is currently causing the vty tests to fail. [1] libosmocore I38edcf902a08b6bd0ebb9aa6fc1a7041421af525 Change-Id: I4a964b86195141e5a50705425206f3602f908999 --- M tests/test_nodes.vty 1 file changed, 4 insertions(+), 24 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index bf2afaf..2be9617 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -27,12 +27,7 @@ OsmoHLR> enable OsmoHLR# list help - list - write terminal - write file - write memory - write - show running-config +... exit disable configure terminal @@ -52,12 +47,7 @@ OsmoHLR# configure terminal OsmoHLR(config)# list help - list - write terminal - write file - write memory - write - show running-config +... exit end ... @@ -66,12 +56,7 @@ OsmoHLR(config)# hlr OsmoHLR(config-hlr)# list help - list - write terminal - write file - write memory - write - show running-config +... exit end gsup @@ -92,12 +77,7 @@ OsmoHLR(config-hlr)# gsup OsmoHLR(config-hlr-gsup)# list help - list - write terminal - write file - write memory - write - show running-config +... exit end bind ip A.B.C.D -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4a964b86195141e5a50705425206f3602f908999 Gerrit-Change-Number: 15698 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: merged