osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 )
Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs ...................................................................... Patch Set 6: Code-Review-1 (3 comments) -1 for lock instead of unlock https://gerrit.osmocom.org/#/c/15560/6/src/logging.c File src/logging.c: https://gerrit.osmocom.org/#/c/15560/6/src/logging.c@924 PS6, Line 924: /*! Find a registered log target. (unrelated change) https://gerrit.osmocom.org/#/c/15560/6/src/logging.c@1014 PS6, Line 1014: log_tgt_mutex_lock(); Shouldn't this be log_tgt_mutex_unlock()? https://gerrit.osmocom.org/#/c/15560/6/src/vty/logging_vty.c File src/vty/logging_vty.c: https://gerrit.osmocom.org/#/c/15560/6/src/vty/logging_vty.c@122 PS6, Line 122: How about placing these two macros in a header file, and using them in gprs_bssgp_vty.c and gprs_ns_vty.c too? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7711893b34263baacac6caf4d489467053131bb Gerrit-Change-Number: 15560 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 09 Oct 2019 08:12:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
