fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 )
Change subject: pcu: add TC_paging_cs_from_bts ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/15623/2/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15623/2/pcu/PCU_Tests_RAW.ttcn@1040 PS2, Line 1040: := Missing space. https://gerrit.osmocom.org/#/c/15623/2/pcu/PCU_Tests_RAW.ttcn@1050 PS2, Line 1050: tr_RLCMAC_DUMMY_CTRL Wait, this is not Paging, this is PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK. If you look at live captures of PDCH, you will see most of them have normal paging mode. Where is the LV you're sending with ts_PCUIF_PAG_REQ? https://gerrit.osmocom.org/#/c/15623/2/pcu/PCU_Tests_RAW.ttcn@1056 PS2, Line 1056: PCU_IF_MSG_TIME_IND We don't have time indications on the BTS port, please remove this comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia3ad503c243c9b3b162e204683fa4fa5447bbab3 Gerrit-Change-Number: 15623 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Assignee: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 09 Oct 2019 08:53:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment