pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 )
Change subject: Initial XTRX support ...................................................................... Patch Set 3: (3 comments) Overall looks fine, please clean up small things I pointed out in this version and in first version of the patch, https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp File Transceiver52M/device/xtrx/XTRXDevice.cpp: https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp@38 PS3, Line 38: // Rx/Tx timestamp difference in samples. Probably cleaner using /* */ https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp@459 PS3, Line 459: Remove extra whitespace at the end. https://gerrit.osmocom.org/#/c/15685/3/contrib/systemd/Makefile.am File contrib/systemd/Makefile.am: https://gerrit.osmocom.org/#/c/15685/3/contrib/systemd/Makefile.am@4 PS3, Line 4: osmo-trx-usrp1.service You miss adding osmo-trx-xtrx.service here. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390 Gerrit-Change-Number: 15685 Gerrit-PatchSet: 3 Gerrit-Owner: rauf.gyulal...@fairwaves.co Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <alexander.cheme...@gmail.com> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 09 Oct 2019 11:51:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
