dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 )
Change subject: gsm0508: add functions to calculate beginning of a block ...................................................................... Patch Set 4: (7 comments) This change is ready for review. https://gerrit.osmocom.org/c/libosmocore/+/15719/2/include/osmocom/gsm/gsm0502.h File include/osmocom/gsm/gsm0502.h: https://gerrit.osmocom.org/c/libosmocore/+/15719/2/include/osmocom/gsm/gsm0502.h@43 PS2, Line 43: tch_f_traffic_block_map > The new should be prefixed with 'gsm0502_' (to be consistent with the > existing code). Done https://gerrit.osmocom.org/c/libosmocore/+/15719/2/include/osmocom/gsm/gsm0502.h@43 PS2, Line 43: static const uint8_t tch_f_traffic_block_map[3][8] = { > I would actually prefer to keep them static and not expose them. […] Done https://gerrit.osmocom.org/c/libosmocore/+/15719/2/include/osmocom/gsm/gsm0502.h@73 PS2, Line 73: traffic > FACCH is not traffic, it's signalling. I would just call it > 'tch_h1_facch_block_map'. Done https://gerrit.osmocom.org/c/libosmocore/+/15719/2/include/osmocom/gsm/gsm0502.h@79 PS2, Line 79: fn_ > Also needs to be prefixed. Done https://gerrit.osmocom.org/c/libosmocore/+/15719/2/src/gsm/gsm0502.c File src/gsm/gsm0502.c: https://gerrit.osmocom.org/c/libosmocore/+/15719/2/src/gsm/gsm0502.c@80 PS2, Line 80: fn_remap_table_from_traffic_block_map > Why not a function? I prefer the macro since it is problematic to use multi dimensional arrays as function parameters. https://gerrit.osmocom.org/c/libosmocore/+/15719/2/src/gsm/gsm0502.c@119 PS2, Line 119: Create BSSMAP Assignment Request message > Completely unrelated. Done https://gerrit.osmocom.org/c/libosmocore/+/15719/2/src/gsm/gsm0502.c@151 PS2, Line 151: default > Makes sense to OSMO_ASSERT() here, or at least print a warning. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3d71c66f8c401f5afbad9b1c86c24580dab9e0ce Gerrit-Change-Number: 15719 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 16 Oct 2019 09:01:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilira...@gmail.com> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment