vvvelichkov has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 )
Change subject: Add code coverage support ...................................................................... Patch Set 7: > Patch Set 6: > > > Let me know if I have to modify some of the ansible playbooks. > > I am not sure if we should enable the coverage checks for every Jenkins > build, maybe rather weekly or monthly. But still, you can find all playbooks > / Dockerfiles at https://git.osmocom.org/osmo-ci/. OK, I reverted all changes in contrib/jenkins_amd64.sh so no coverage reports from the Jenkins builds. I've also removed m4/osmo_code_coverage.m4 as it was leftover after I renamed in to m4/osmo_ac_code_coverage.m4 To add coverage reports to another osmocom project you need to add OSMO_AC_CODE_COVERAGE in configure.ac and @CODE_COVERAGE_RULES@ in the toplevel Makefile.am. In case you've installed libosmocore in a custom prefix (not in /usr/local/) you may need to call autoreconf with "-I <prefix>/share/aclocal/", add this path to ACLOCAL_PATH or add it in acdir/dirlist. See https://www.gnu.org/software/automake/manual/html_node/Macro-Search-Path.html -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f4ffb91bd7f3dd070aa09dd16d5ad1faf130a4c Gerrit-Change-Number: 13496 Gerrit-PatchSet: 7 Gerrit-Owner: vvvelichkov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: vvvelichkov <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2019 00:07:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
