Change in osmo-bsc[master]: rsl: Send IE MS Power Param to osmocom BTS models only

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/15891 )

Change subject: rsl: Send IE MS Power Param to osmocom BTS models only
......................................................................

rsl: Send IE MS Power Param to osmocom BTS models only

Since MS Power Param IE content is operator dependant, it's currently
not known which kind of content non-osmocom BTS support/allow, so let's
avod possibily breaking those BTS until each BTS has been checked
separately.

Related: OS#1622
Change-Id: If44121222042bdac06c2a5e70f7b35a88b00b27c
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 6ffa415..d4917f2 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -319,7 +319,11 @@

        msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);
        /* indicate MS power control to be performed by BTS: */
-       msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+       if (bts->type == GSM_BTS_TYPE_OSMOBTS)
+               msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+       /* else: Since IE MS_POWER_PARAM content is operator dependent, it's not
+          known if non-osmocom BTS models will support an empty IE, so let's
+          better skip sending it unless we know for sure what each expects. */

        msg->dst = trx->rsl_link;

@@ -548,7 +552,11 @@
        msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);
        msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta);
        /* indicate MS power control to be performed by BTS: */
-       msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+       if (bts->type == GSM_BTS_TYPE_OSMOBTS)
+               msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+       /* else: Since IE MS_POWER_PARAM content is operator dependent, it's not
+          known if non-osmocom BTS models will support an empty IE, so let's
+          better skip sending it unless we know for sure what each expects. */

        mr_config_for_bts(lchan, msg);


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15891
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If44121222042bdac06c2a5e70f7b35a88b00b27c
Gerrit-Change-Number: 15891
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-MessageType: merged