neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16029 )
Change subject: fix osmo_quote_str_c() to alloc sufficient size ...................................................................... Patch Set 4: (1 comment) osmo_quote_str* functions would make for an interesting anecdotal review of various ways of composing strings that we (I?) thought were great but later needed improving upon. https://gerrit.osmocom.org/c/libosmocore/+/16029/4/src/utils.c File src/utils.c: https://gerrit.osmocom.org/c/libosmocore/+/16029/4/src/utils.c@780 PS4, Line 780: * \return Number of characters that would be written if bufsize were large enough excluding '\0' (like snprintf()). interestingly enough, the \return doc didn't need any change, it was plain wrong for osmo_quote_str_buf2() :/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I04d97e8eec93ffb74006503c356a68cceaf429ac Gerrit-Change-Number: 16029 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Mon, 11 Nov 2019 20:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
