osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15961 )
Change subject: add osmo_sockaddr_str_cmp() ...................................................................... Patch Set 6: Code-Review+1 (3 comments) LGTM, only cosmetics. https://gerrit.osmocom.org/c/libosmocore/+/15961/6/src/sockaddr_str.c File src/sockaddr_str.c: https://gerrit.osmocom.org/c/libosmocore/+/15961/6/src/sockaddr_str.c@99 PS6, Line 99: ingore (ignore) https://gerrit.osmocom.org/c/libosmocore/+/15961/6/src/sockaddr_str.c@117 PS6, Line 117: if (cmp) : return cmp; : return 0; Why this instead of simply "return cmp"? https://gerrit.osmocom.org/c/libosmocore/+/15961/6/tests/sockaddr_str/sockaddr_str_test.c File tests/sockaddr_str/sockaddr_str_test.c: https://gerrit.osmocom.org/c/libosmocore/+/15961/6/tests/sockaddr_str/sockaddr_str_test.c@257 PS6, Line 257: 0? (missing space) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0dbc1cf707098dcda75f8e07c1b936951f9f9501 Gerrit-Change-Number: 15961 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2019 08:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
