pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16203 )

Change subject: add osmo-mslookup-client program
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/configure.ac
File configure.ac:

https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/configure.ac@187
PS9, Line 187:  contrib/dgsm/Makefile
I don't think contrib is the right place for this. either util(s)/ or tests/


https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/src/mslookup/osmo-mslookup-client.c
File src/mslookup/osmo-mslookup-client.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/src/mslookup/osmo-mslookup-client.c@89
PS9, Line 89: "$ osmo-mslookup-client -s /tmp/mslookup -d\n"
So the daemon is called client? and a client then connects to it? mindblowing.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16203
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ie68a5c1db04fb4dff00dc3c774a1162f5b9fabf7
Gerrit-Change-Number: 16203
Gerrit-PatchSet: 9
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to