neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16189 )
Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*() ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c File src/gsm/gsup.c: https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c@985 PS3, Line 985: osmo_gsup_message_name_buf > I think the naming is wrong. […] Maybe you're thinking of osmo_gsup_message_type_name() which we have for the the message type? The intention is: with the pattern being osmo_foo_name to get a human readable representation of foo, here foo is gsup_message. So it's a string of the GSUP message, indeed. Should I choose another name? which one? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9692880079ea0f219f52d81b1923a76fc640566 Gerrit-Change-Number: 16189 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2019 20:23:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
