neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16203 )
Change subject: add osmo-mslookup-client program ...................................................................... Patch Set 9: (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/configure.ac@187 PS9, Line 187: contrib/dgsm/Makefile > I don't think contrib is the right place for this. […] The osmo-mslookup-client utility is in src/mslookup. contrib/dgsm/ just has two python examples that use this osmo-mslookup-client utility program. https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/src/mslookup/osmo-mslookup-client.c File src/mslookup/osmo-mslookup-client.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16203/9/src/mslookup/osmo-mslookup-client.c@89 PS9, Line 89: "$ osmo-mslookup-client -s /tmp/mslookup -d\n" > So the daemon is called client? and a client then connects to it? mindblowing. It is a client really, and it does indeed seem really odd. I thought about this from various angles, in mild disbelief of what weird program I had just written. But after all it does make sense as soon as you want to implement a blocking client. The simpler way is just a cmdline tool returning a string on stdout. The more complex socket way provides a sort of proxy: it returns only those results that match your own query, while allowing many different queries to be handled on the same multicast socket, and without spawning a new process for each and every request. I guess I should clarify the doc? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ie68a5c1db04fb4dff00dc3c774a1162f5b9fabf7 Gerrit-Change-Number: 16203 Gerrit-PatchSet: 9 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2019 21:53:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
