laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15888 )
Change subject: l1sap: add measurement related struct members ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h File include/osmocom/gsm/l1sap.h: https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@87 PS2, Line 87: flags > What is the purpose of these flags? And why only one bit? the flag determines whether a given measurement is part of the "RXLEV/RXQUAL-SUB", and not just -FULL. The SUB are contained of all SACCH blocks in uplink, plus some other blocks. Which blocks depends on the codec. FR/EFR/HR have some static block numbers (IIRC) while in AMR it's actually dynamically decided whcih block is part of SUB and which not. https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@99 PS2, Line 99: ta_offs_qbits > The measurement processing makes use of this field, so its needed. […] Indeed it's unclear why this is part of libosmocore. Maybe jolly wanted to also use it in other software outside of osmo-bts? In any case I'm not aware of such software. Maybe ask him directly, or on the mailing list. In any case, I think it's not a good idea to merge changes here if you don't fully understand what they do, sorry. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c34b02d329f9df190c5035c396403ca0a4f9c42 Gerrit-Change-Number: 15888 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2019 15:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
