laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16206 )

Change subject: gsup client: add up_down_cb(), add osmo_gsup_client_create3()
......................................................................


Patch Set 19:

(1 comment)

https://gerrit.osmocom.org/c/osmo-hlr/+/16206/19/include/osmocom/gsupclient/gsup_client.h
File include/osmocom/gsupclient/gsup_client.h:

https://gerrit.osmocom.org/c/osmo-hlr/+/16206/19/include/osmocom/gsupclient/gsup_client.h@67
PS19, Line 67:                                            struct 
osmo_oap_client_config *oapc_config,
At some point it makes sense to pass a strict instead of dozens of arguments



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16206
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I6f181e42b678465bc9945f192559dc57d2083c6d
Gerrit-Change-Number: 16206
Gerrit-PatchSet: 19
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Comment-Date: Sat, 30 Nov 2019 10:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to