neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16212 )
Change subject: drop error log for when a subscriber does not exist ...................................................................... Patch Set 23: > Patch Set 22: > > It could at least be a DEBUG message. Or are we sure that all users of the db > API will always log themselves? All callers (except some vty cmd implementations, s.b.) issue an error message if they expect a subscriber and can't find one. Arguably the vty should not LOGP() but vty_out() anyway. When checking I found some minor rc evaluation issues and created https://osmocom.org/issues/4303 A LOGL_DEBUG message could be ok, but after looking at the code that seems like log spam / duplication. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5044e9b4519b948edc4e451cef0f7830d315619b Gerrit-Change-Number: 16212 Gerrit-PatchSet: 23 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2019 23:07:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
