neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16210 )
Change subject: add mslookup_manual_test ...................................................................... Patch Set 23: > Patch Set 22: > > I would really love to see those kind of tests done in ttcn3. There we have > GSUP, VTY and Im sure also a DNS module exists. The added benefit is that the > Tests dont usw the same implementation of encoding/decoding. > > Sure it wastes time to redo it. But it Paine me to See that in 2019 we still > are writing non-,unit-,Tests outside oft ttcn3. Festung external network > interfaces is not a unit test! This was a quick and dirty test setup i needed for testing interaction between 4 HLRs and what to expect when real world traffic happens in that situation; I posted before that we don't really need to merge this patch at all (but comments in gerrit are pretty hard to spot IMHO). ttcn tests are osmith's task :) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I80473528c9524263b60fc3ba37ba246c80bfe452 Gerrit-Change-Number: 16210 Gerrit-PatchSet: 23 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2019 23:14:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
