laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16472 )
Change subject: e1cap_dump: Avoid deprecated osmo_init_logging() API ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16472/1/src/e1cap_dump.c File src/e1cap_dump.c: https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16472/1/src/e1cap_dump.c@291 PS1, Line 291: osmo_init_logging2(NULL, &log_info); > The idea is to avoid using talloc ctx NULL :) I kno,w but this small one-shot command line tool is not using talloc anywhere. It has no talloc contexts, nor does it have nay talloc reporting. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I7d9d88eb5615f6b323b6c36eceb4d847bae01d1d Gerrit-Change-Number: 16472 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Dec 2019 14:59:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
