fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502 )
Change subject: pcu: Introduce helpers to update AckNackDescription ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502/3/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502/3/pcu/PCU_Tests_RAW.ttcn@577 PS3, Line 577: f_acknackdesc_init Rather use a template instead of this imperative approach. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502/3/pcu/PCU_Tests_RAW.ttcn@801 PS3, Line 801: uint7_t exp_bsn := 0 Feel free to use a template (present) here with default := ?. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502/3/pcu/PCU_Tests_RAW.ttcn@816 PS3, Line 816: if (dl_block.data.mac_hdr.hdr_ext.bsn != exp_bsn) { ... so than here you could just use match(). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502/3/pcu/PCU_Tests_RAW.ttcn@1466 PS3, Line 1466: 0 It's 0 by default in the function definition. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic62ab9e4a854239b95c434068543d95c5352f1c6 Gerrit-Change-Number: 16502 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 05 Dec 2019 18:24:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
