pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16528 )
Change subject: pcu: Introduce tests for CS and PS paging from SGSN/Gb ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16528/2/library/GSM_RR_Types.ttcn File library/GSM_RR_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16528/2/library/GSM_RR_Types.ttcn@924 PS2, Line 924: omit > Rather add a second argument to the template (or use '*'). That's fine for now, it's what we expect. If someones needs more later they can extend it. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16528/2/library/Osmocom_Gb_Types.ttcn File library/Osmocom_Gb_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16528/2/library/Osmocom_Gb_Types.ttcn@1235 PS2, Line 1235: BssgpBvci > template BssgpBvci ... No template around here uses template for bvci, since usually you either want to check against a PTP or signalling bvci afaiu. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90b5a792c1d91e38ea7b8c060ff0b459673df951 Gerrit-Change-Number: 16528 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 23 Dec 2019 13:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
