pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15359 )
Change subject: vty: show subscriber: change format of 'last LU seen' ...................................................................... Patch Set 18: (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/15359/18/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/15359/18/src/hlr_vty_subscr.c@43 PS18, Line 43: tm = gmtime(t); Better use gmtime_r() to avoid possible issues if more threads are used later on. It's cheap doing it now and we avoid future issues. https://gerrit.osmocom.org/c/osmo-hlr/+/15359/18/src/hlr_vty_subscr.c@45 PS18, Line 45: return "UNKNOWN"; is this string static? Or appended to the stack? Better strcpy() it to buf since we already have it. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I6731968f05050399f4dd43b241290186e0c59e1a Gerrit-Change-Number: 15359 Gerrit-PatchSet: 18 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 14:59:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
