laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/16833 )

Change subject: application.c: check default loglevels on startup
......................................................................


Patch Set 4: Code-Review-1

I would think it's sufficient to go through all applications (it's not that 
many, after all) and ensure that the current code doesn't have any compiled-in 
default log level below NOTICE or INFO.  In the future we should pay attention 
during code review to prevent new such bugs from being introduced.  I would 
expect they date back to our pre-gerrit development days.

This way thre's no need for enforcement in libosmocore, which may create 
problems as pau indicates.


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16833
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2d7e345c14a188430a0e991bfd9fb0343d05ea92
Gerrit-Change-Number: 16833
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jan 2020 16:04:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to