pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16885 )
Change subject: ta_control: move timing advance code from osmo-bts-trx to common ...................................................................... Patch Set 2: Code-Review-1 (6 comments) You are adding binary file tests/ta_control/ta_control_test. Make sure to remove it and add an entry in gitignore. https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/include/osmo-bts/ta_control.h File include/osmo-bts/ta_control.h: https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/include/osmo-bts/ta_control.h@3 PS2, Line 3: #include <stdint.h> This header here is not needed at all. If upon removing it compilation fails, then the issue is somewhere else and you should fix it in a previous separate commit. https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/src/common/ta_control.c File src/common/ta_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/src/common/ta_control.c@42 PS2, Line 42: } else if (toa256 > TOA256_9OPERCENT && lchan->rqd_ta < 63) { would be nice having this 63 in some define. https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/src/osmo-bts-trx/trx_vty.c@196 PS2, Line 196: vty_out (vty, "'no osmotrx timing-advance-loop' is deprecated%s", VTY_NEWLINE); I'd add some string telling the user that no extra operation is needed, TA loop will be enabled by default? https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c File tests/ta_control/ta_control_test.c: https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c@43 PS2, Line 43: for (i=0; i<steps; i++) { spacing i = 0; i < steps https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c@47 PS2, Line 47: whitespace https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c@55 PS2, Line 55: whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If7ddf74db3abc9b9872abe620a0aeebe3327e70a Gerrit-Change-Number: 16885 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2020 12:15:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
