laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16901 )
Change subject: sccp: Improve logging in sccp_to_xua_opt() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmo-sccp/+/16901/2/src/sccp_types.c File src/sccp_types.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/16901/2/src/sccp_types.c@36 PS2, Line 36: OSMO_VALUE_STRING(SCCP_PNC_SEGMENTING), same here. Having "SCCP_PNC_" as a prefix in every related log message is of no benefit to the user. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icb3f18f34ecfe0602c6e491b61107a30287dcafb Gerrit-Change-Number: 16901 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 16 Jan 2020 20:26:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment