fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16206 )
Change subject: gsup client: add up_down_cb(), add osmo_gsup_client_create3() ...................................................................... Patch Set 28: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16206/28/include/osmocom/gsupclient/gsup_client.h File include/osmocom/gsupclient/gsup_client.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16206/28/include/osmocom/gsupclient/gsup_client.h@62 PS28, Line 62: osmo_gsup_client_config That's a nice idea to finally group all parameters into a structure! https://gerrit.osmocom.org/c/osmo-hlr/+/16206/28/include/osmocom/gsupclient/gsup_client.h@69 PS28, Line 69: tcp_port Just an idea: what if somebody wants to use a different transport layer, e.g. SCTP? We could make the new function more flexible by adding an enumerated type (osmo_gsup_transport_proto?) and a union to this structure: ... enum osmo_gsup_transport_proto transport_proto; const char *ip_addr; union { struct tcp_ipa { struct ipaccess_unit *ipa_dev; unsigned int port; } } u; ... For now osmo_gsup_client_create3() would return -ENOTSUPP for transport_proto != TCP_IPA. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I6f181e42b678465bc9945f192559dc57d2083c6d Gerrit-Change-Number: 16206 Gerrit-PatchSet: 28 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2020 09:51:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
