fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17548 )
Change subject: rlcmac: Fix bug receiving RA cap ...................................................................... Patch Set 7: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.cpp File tests/rlcmac/RLCMACTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.cpp@461 PS7, Line 461: Make sure there's 1 value (currently fails due to failed decoding) please update this comment too https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.ok File tests/rlcmac/RLCMACTest.ok: https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.ok@146 PS7, Line 146: decode_gsm_ra_cap() returns 0 to be consistent, I would also print this line from the new test -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2020 16:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
