fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/17595 )

Change subject: doc: do not set the base-port of the trx
......................................................................


Patch Set 1: Code-Review-1

I am sorry, but what's the point of this change? I believe the configuration 
examples should contain all available options, so there is no need to refer 
documentation / source code every time you need to remember position / format 
of some option. Look at configuration examples of srsLTE - everything is listed 
and documented there, so you don't have to leave your text editor at all.


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4
Gerrit-Change-Number: 17595
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2020 07:46:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to