dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/17594 )

Change subject: doc: switch log levels to notice
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
>
> > Patch Set 1:
> >
> > I usually use osmo-trx with info level set and it looks good for me. I like 
> > seeing the clock indications to see that everything's smoothly. I'm not 
> > against the patch though, just sharing my opinion.
>
> Same here, I am fine with INFO. Clock indications can be suspended by setting 
> DTRXCLK to NOTICE. And I don't see what a regular user would benefit from 
> this change... among with sending us even less informative bug reports.

The problem here is that the default config files are also installed to /etc/ 
by the package manager. I would argue to be frugal with log output but I also 
see your point.


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17594
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ief82b85d9ff0e0e94eaabd255ebea961396fff32
Gerrit-Change-Number: 17594
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2020 12:38:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to