pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17612 )

Change subject: srs_enb: add modifier to pass arbitrary cmd line arguments
......................................................................


Patch Set 1: Code-Review-2

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17612/1/example/scenarios/mod-srsenb-args%40.conf
File example/scenarios/mod-srsenb-args@.conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17612/1/example/scenarios/mod-srsenb-args%40.conf@3
PS1, Line 3: <%
I don't like this. Let's not add fancy template features to scenarios, only 
param1..N variables.

Rather keep it as a string in param1, and convert the string into the 
list/tuple of params in srs_ue.py.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17612/1/src/osmo_gsm_tester/srs_enb.py
File src/osmo_gsm_tester/srs_enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17612/1/src/osmo_gsm_tester/srs_enb.py@159
PS1, Line 159:                 self._conf.get('additional_args') if 
self._conf.get('additional_args') is not None else '')
Do the conversion here from 1 string into several params



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17612
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I3e8100e4e79acb49ee6e8bfb4f3bc2ea41c9f6b6
Gerrit-Change-Number: 17612
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <an...@softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2020 14:58:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to