pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285 )
Change subject: bts: Add RTP payload testing to performance tests ...................................................................... Patch Set 3: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/3/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/3/bts/BTS_Tests.ttcn@546 PS3, Line 546: setverdict(fail, "pars.num_rtpem_chans exceeds number of possible RTPEM channels"); You could print sizeof(vc_RTPEM) here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/3/bts/BTS_Tests.ttcn@549 PS3, Line 549: for (var integer i := 0; i < sizeof(vc_RTPEM); i := i+1) { i < num_rtpem_chans https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/3/bts/BTS_Tests.ttcn@637 PS3, Line 637: num_rtpem_chans := omit I wonder what's the point of using omit and isbound() and not simply passing 0 here... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21a610533d5be2e1647cc6a72423e056b39d1217 Gerrit-Change-Number: 17285 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2020 16:55:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
