srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681 )
Change subject: Introduce initial Amarisoft ENB support ...................................................................... Patch Set 3: (2 comments) ah, just found that here. I know it has been merged already ;-) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/example/defaults.conf File example/defaults.conf: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/example/defaults.conf@113 PS2, Line 113: license_server_addr: 10.12.1.139 not sure if it makes sense to provide a default value here. It's like wrong. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/src/osmo_gsm_tester/amarisoft_enb.py File src/osmo_gsm_tester/amarisoft_enb.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/src/osmo_gsm_tester/amarisoft_enb.py@216 PS2, Line 216: def ue_max_rate(self, downlink=True): seeing that 1:1 again, I think it makes sense to add a eNB base class, a Ericsson eNB will have the same max rates. ah, just saw you added one, so let's move the max_rate() to this class -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I1ddf4962ea6438ad977382ab201b724028ca46b3 Gerrit-Change-Number: 17681 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: srs_andre <an...@softwareradiosystems.com> Gerrit-Comment-Date: Tue, 31 Mar 2020 10:06:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment