pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17758 )
Change subject: sgsnemu: Refactor arg/cfg parser to use talloc ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/17758/2/sgsnemu/cmdline.c File sgsnemu/cmdline.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/17758/2/sgsnemu/cmdline.c@2 PS2, Line 2: File autogenerated by gengetopt version 2.22.6 : generated with the following command: > you are aware that you are modifing a file that's generated code? If you > really want to go there, y […] I was not aware, probably because nobody is generating anything anymore not in my opinion should generate anything anymore here. If at all, we should move all this into a vty config like we did for osmo-trx. I don't see an easy way to do this patch with whatever tool, so either we drop it and we all continue having memleaks or accept that nobody is willing o generate anything anymore and keep moving forward using talloc features and further in the future libosmovty. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ie0d48a12a8349be5a859a03191421cbd9cc324cc Gerrit-Change-Number: 17758 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sat, 11 Apr 2020 14:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
