laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965 )
Change subject: library/RLCMAC: Add partial support for EGPRS data block encoding/decoding ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965/3/library/RLCMAC_EncDec.cc File library/RLCMAC_EncDec.cc: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965/3/library/RLCMAC_EncDec.cc@297 PS3, Line 297: fprintf(stderr, "RLMAC: clone: hdr_bytes=%u extra_bits=%u (length_bytes=%u)\n", hdr_bytes, extra_bits, length_bytes); do we really want unconditional prints to stderr in non-error paths? same applies to more messages down below. If they're not errors, they should go to stdout. And if they are just for debugging the code, they should be default-off and enabled by some kind of environment variable or function to call for enablign it dynamically. And in general, it might be the best choice to use the TITAN logging framework to integrate with the other logging in titan native code. This way it can be enabled/disabled via normal titan config files. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2bc4f877a5e17c57ffa8cf05565dc8593b45aae8 Gerrit-Change-Number: 17965 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 28 Apr 2020 16:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
