Hello pespin, fixeria, laforge, osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16459
to look at the new patch set (#10).
Change subject: 2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union
......................................................................
2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union
To be prepared for the future in public API, wrap the new osmo_ipa_name struct
in an enum-type and union called osmo_cni_peer.
During code review it was requested to insert an ability to handle different
kinds of peer id, in order to be able to add a Global Title in the future.
Use the generic osmo_cni_peer only in the publicly visible API. For osmo-hlr
internal code, I intend to postpone implementing this into the future, when a
different peer identification actually gets introduced.
This way we don't need to implement it now in all osmo-hlr code paths (save
time now), but still make all external API users aware that this type may be
extended in the future.
Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
---
M include/Makefile.am
A include/osmocom/gsupclient/cni_peer_id.h
M include/osmocom/gsupclient/gsup_req.h
D include/osmocom/gsupclient/ipa_name.h
M include/osmocom/hlr/db.h
M include/osmocom/hlr/gsup_server.h
M src/Makefile.am
M src/db_hlr.c
M src/gsup_server.c
M src/gsupclient/Makefile.am
A src/gsupclient/cni_peer_id.c
M src/gsupclient/gsup_req.c
D src/gsupclient/ipa_name.c
M src/hlr.c
M src/hlr_ussd.c
M src/lu_fsm.c
M tests/db/Makefile.am
M tests/db/db_test.c
M tests/gsup_server/Makefile.am
19 files changed, 346 insertions(+), 181 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/59/16459/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
Gerrit-Change-Number: 16459
Gerrit-PatchSet: 10
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: newpatchset
