laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16214 )
Change subject: hlr_vty_subscr: prettier output for last LU seen ...................................................................... hlr_vty_subscr: prettier output for last LU seen Extend the "last LU seen on ..." line with the amount of seconds that passed since now, or "(invalid timestamp)". Patch split from Id7fc50567211a0870ac0524f6dee94d4513781ba, because it depends on timestamp_age which was just added in Ife4a61d71926d08f310a1aeed9d9f1974f64178b. Change-Id: I24f9e86c1aa0b1576290094e024562f41b988f37 --- M src/hlr_vty_subscr.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/hlr_vty_subscr.c b/src/hlr_vty_subscr.c index b561636..14a37f2 100644 --- a/src/hlr_vty_subscr.c +++ b/src/hlr_vty_subscr.c @@ -30,6 +30,7 @@ #include <osmocom/hlr/hlr.h> #include <osmocom/hlr/db.h> +#include <osmocom/hlr/timestamp.h> struct vty; @@ -49,11 +50,15 @@ static void dump_last_lu_seen(struct vty *vty, const char *domain_label, time_t last_lu_seen) { + uint32_t age; char datebuf[26]; /* for ctime_r(3) */ if (!last_lu_seen) return; - vty_out(vty, " last LU seen on %s: %s UTC%s", domain_label, get_datestr(&last_lu_seen, datebuf), - VTY_NEWLINE); + vty_out(vty, " last LU seen on %s: %s UTC", domain_label, get_datestr(&last_lu_seen, datebuf)); + if (!timestamp_age(&last_lu_seen, &age)) + vty_out(vty, " (invalid timestamp)%s", VTY_NEWLINE); + else + vty_out(vty, " (%us ago)%s", age, VTY_NEWLINE); } static void subscr_dump_full_vty(struct vty *vty, struct hlr_subscriber *subscr) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I24f9e86c1aa0b1576290094e024562f41b988f37 Gerrit-Change-Number: 16214 Gerrit-PatchSet: 35 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: merged