pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18002 )
Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/18002/2/TODO-RELEASE File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmocore/+/18002/2/TODO-RELEASE@12 PS2, Line 12: sim API/ABI change all over the place this line is non-related to this commit. https://gerrit.osmocom.org/c/libosmocore/+/18002/2/src/gsm/lapd_core.c File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/18002/2/src/gsm/lapd_core.c@308 PS2, Line 308: dl->name = talloc_strdup(tall_lapd_ctx, name); to check: is it fine calling talloc_stdup() on NULL ptr? https://gerrit.osmocom.org/c/libosmocore/+/18002/2/src/gsm/lapdm.c File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/18002/2/src/gsm/lapdm.c@189 PS2, Line 189: * \param[in] name human-readable name (will be copied internally) mention the name is changed to contain offset. https://gerrit.osmocom.org/c/libosmocore/+/18002/2/src/gsm/lapdm.c@256 PS2, Line 256: * \parma[in] name_pfx human-readable name (copied by function) mention it's a prefix (stuff is appended to it). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Gerrit-Change-Number: 18002 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 02 May 2020 22:44:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
