pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17973 )
Change subject: VTY: make configurable: X23002, X23005, X23006 ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/17973/4/src/osmo-bsc/net_init.c File src/osmo-bsc/net_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17973/4/src/osmo-bsc/net_init.c@48 PS4, Line 48: { .T=-23002, .default_val=5, .desc="Wait time for RSL Channel Activate ACK after sending RSL Channel Activate" }, Better move negative ones to a separate block (inside this same array) to clearly differentiate osmo specific ones vs spec ones. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb Gerrit-Change-Number: 17973 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 04 May 2020 08:13:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
