pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 )
Change subject: e1_input: Add VTY command to enable PCAP debug output ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c File src/e1_input_vty.c: https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c@267 PS1, Line 267: e1_set_pcap_fd(-1); > We can't. […] will it be closed when all the lines using it become inactive? (can that ever happen?) In that we'd need to haver some sort of reference counting applied here (we have APIs for reference counting in libosmocore). -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454 Gerrit-Change-Number: 18114 Gerrit-PatchSet: 3 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2020 13:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: tnt <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
