laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18157 )
Change subject: fix egprs_mslot_class_from_ra(): multislot class may not be present ...................................................................... fix egprs_mslot_class_from_ra(): multislot class may not be present For more details, see 3GPP TS 44.060, table 11.2.5a.2. Change-Id: Iba0466b29afd26cff317ed4fb6749f8a3079f16a Signed-off-by: Vadim Yanitskiy <[email protected]> Related: OS#1548 --- M src/bts.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 6578e06..1d073aa 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -675,7 +675,8 @@ */ static inline uint8_t egprs_mslot_class_from_ra(uint16_t ra, bool is_11bit) { - if (is_11bit) + /* EGPRS multislot class is only present in One Phase Access Request */ + if (is_11bit && (ra >> 10) == 0x00) /* .0xx xxx. .... */ return ((ra & 0x3e0) >> 5) + 1; /* set EGPRS multislot class to 0 for 8-bit RACH, since we don't know it yet */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iba0466b29afd26cff317ed4fb6749f8a3079f16a Gerrit-Change-Number: 18157 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-MessageType: merged
