fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18134 )
Change subject: Expect ms object to exist before calling tbf_alloc_dl_tbf() ...................................................................... Patch Set 1: Code-Review+2 (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp@1055 PS1, Line 1055: int rc; Makes sense to add OSMO_ASSERT(ms != NULL) here, like you did in the previous change. https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp@1057 PS1, Line 1057: ms->egprs_ms_class() == 0 So if we're in 'EGPRS only' mode, and both egprs_ms_class and ms_class == 0, then a phone gets accepted just fine? Just trying to understand the logic behind this, not related to this change. https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp@1063 PS1, Line 1063: ms->set_egprs_ms_class(1); Wow, unrelated question: why do we overwrite the MS class here? o_O -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I87f6cdf8288a688466020bda0874e68b57aa71c4 Gerrit-Change-Number: 18134 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 12 May 2020 16:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
