laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333 )
Change subject: Move all GPRS helper function to its own file and component ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn@168 PS2, Line 168: f_pcuif_rx_imm_ass > compilation fails if I leave "private", I tested it. you can also use 'friend'. it depends a bit if you think it is a public function for everyone to use,or if it is more some internal function with 1-2 callers (also in the future) and hence the private/friend mechanism might be better in terms of encapsulation. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieae27d6e707f79ec2145864ef5cd67ddbbec9314 Gerrit-Change-Number: 18333 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 18 May 2020 15:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-MessageType: comment
